Swift support #277
Merged
Swift support #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # detox/src/devices/Device.js # detox/src/devices/IosDriver.js
|
|
||
| program | ||
| .option('-r, --runner [runner]', 'Test runner (currently supports mocha)', 'mocha') | ||
| .parse(process.argv); | ||
|
|
||
| function createFile(dir, content) { | ||
| try { | ||
| try { |
There was a problem hiding this comment.
We should really add in prettier, these changes just obfuscate the diff.
|
|
||
| if (os.platform() === 'darwin') { | ||
| const frameworkPath = path.join(os.homedir(), '/Library/Detox'); | ||
| console.log(`Removing framework binaries from ${frameworkPath}`); |
There was a problem hiding this comment.
Why not use our default log library?
| @@ -1,14 +1,18 @@ | |||
| #!/bin/bash | |||
| #!/bin/bash -e | |||
|
@rotemmiz Is this fix likely to address app crashes on start like the below; which I started getting after an XCode 9 (and implicit Swift 3.2) upgrade? Or should I open a ticket? Just trying to avoid noise for you all if possible. (Answering my own question - yes this is fixed with Detox 5.7.0 which was released a matter of hours after I added this comment originally!) |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, users who use swift in their projects may not be able to use Detox if their swift version is different than the one shipped in Detox.framework.
From Detox@5.7.0 we will start compiling Detox.framework on the user's machine, to better support different Swift versions.
Relates to #152