Improvements in setup of jest runner. Update GettingStarted documentation. #329
Conversation
We should probably keep the same patterns with defining E2E test like unit in jest (talking about __tests__ pattern). Also setup can be in one file if we conditionally load `detox` object. How do you feel about this? :)
ice-chillios
changed the title
docs/Guide.Jest.md
Outdated
| await detox.init(config); | ||
| }); | ||
| // setup detox only when running e2e tests | ||
| if (process.argv[2].includes('__e2e__')) { |
There was a problem hiding this comment.
This is not needed when we specify the setup files, which I think is a cleaner approach
There was a problem hiding this comment.
I thought about one file of setup for all environment (including unit tests). But we can run this file specifically for e2e tests as you mention :)
docs/Guide.Jest.md
Outdated
| ``` | ||
|
|
||
| ### 4. Run jest | ||
|
|
||
| Add this part to your `package.json`: | ||
| ```json | ||
| "jest": { | ||
| "preset": "react-native", |
There was a problem hiding this comment.
You don't need this jest config as we run on the build app
There was a problem hiding this comment.
As above, I had in my mind to create a unified setup for unit and e2e but You are correct, for e2e test we do not need it :)
docs/Guide.Jest.md
Outdated
| @@ -19,32 +19,39 @@ You should remove `e2e/mocha.opts`, you no longer need it. | |||
| ### 3. Write a detox setup file | |||
|
|
|||
| ```js | |||
| // ./jest/setup/ | |||
docs/Guide.Jest.md
Outdated
| "scripts": { | ||
| "test:e2e": "jest e2e --setupTestFrameworkScriptFile=./jest/setup-e2e-tests.js --runInBand" | ||
| "test:e2e": "detox build && jest __e2e__ --runInBand" |
There was a problem hiding this comment.
The build part is left out because with detox test it isn't included either, but adding something like test:e2e:build: "detox build" is a pretty neat idea!
|
I've applied some changes to this one @DanielMSchmidt. If anything more is bothering You add more notes :) |
We should probably keep the same patterns with defining E2E test like unit in jest (talking about tests pattern). Also setup can be in one file if we conditionally load
detoxobject. How do you feel about this? :) @DanielMSchmidt