Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

iOS: Support spaces in app name #626

Merged
merged 2 commits into from
Mar 17, 2018
Merged

iOS: Support spaces in app name #626

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6797832
Support spaces in iOS app name
lukefanning Mar 14, 2018
dd0d6a7
Fixed the unit test for spaces in paths
lukefanning Mar 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion detox/src/devices/AppleSimUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ class AppleSimUtils {
trying: `Installing ${absPath}...`,
successful: `${absPath} installed`
};
await this._execSimctl({ cmd: `install ${udid} ${absPath}`, statusLogs });
await this._execSimctl({ cmd: `install ${udid} "${absPath}"`, statusLogs });
}

async uninstall(udid, bundleId) {
Expand Down
4 changes: 2 additions & 2 deletions detox/src/devices/SimulatorDriver.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class SimulatorDriver extends IosDriver {
const detoxFrameworkPath = await environment.getFrameworkPath();

if (!fs.existsSync(detoxFrameworkPath)) {
throw new Error(`${detoxFrameworkPath} could not be found, this means either you changed a version of Xcode or Detox postinstall script was unsuccessful.
throw new Error(`${detoxFrameworkPath} could not be found, this means either you changed a version of Xcode or Detox postinstall script was unsuccessful.
To attempt a fix try running 'detox clean-framework-cache && detox build-framework-cache'`);
}
}
Expand All @@ -31,7 +31,7 @@ class SimulatorDriver extends IosDriver {

async getBundleIdFromBinary(appPath) {
try {
const result = await exec(`/usr/libexec/PlistBuddy -c "Print CFBundleIdentifier" ${path.join(appPath, 'Info.plist')}`);
const result = await exec(`/usr/libexec/PlistBuddy -c "Print CFBundleIdentifier" "${path.join(appPath, 'Info.plist')}"`);
const bundleId = _.trim(result.stdout);
if (_.isEmpty(bundleId)) {
throw new Error();
Expand Down