Prevent bugs with older _.isFunction prior to lodash@4.14.1 #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unctions. Closes #805.
rotemmiz
approved these changes
Jul 3, 2018
rotemmiz
changed the title
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Detox has a very relaxed Lodash version requirement (
^4.14.1in package.json), one of our users (@tachtevrenidis) had an issue (#805) when the older_.isFunctioncould not recognizeasync function.Although, the issue itself was addressed quite a long time ago, in lodash/lodash@95bc54a , nevertheless I suggest this patch to prevent the further occurrences of this bug. This patch is too hard to locate and too expensive to debug (1+ hour of remote debug session in a video call).
@rotemmiz , can we get it merged soon? Many thanks in advance!!!!