6348 - Deunify FilesInUse messages in Burn #67
Conversation
| // | ||
| // Return: |
There was a problem hiding this comment.
Why remove these? This is the only "doc" without spelunking source.
There was a problem hiding this comment.
You mean source code? Burn doesn't own how the return codes are processed. The BA needs to look at the source of the FilesInUse message and return a value based on that source's documentation which is provided as a link here.
There was a problem hiding this comment.
I didn't realize it was just pass-through. Hopefully we'll never need more than an int...
There was a problem hiding this comment.
I guess it's not exactly pass-through, there's still some coercion by calling UserExperienceCheckExecuteResult. I wasn't sure whether to remove that, too.
There was a problem hiding this comment.
Seems that it should be completely pass-through (though we still want to be able to talk to Burn) or translate Burn return values to the underlying engine (as Burn is hard-coded for the ones it supports).
| /// <summary> | ||
| /// Generated from INSTALLMESSAGE_RMFILESINUSE. | ||
| /// </summary> | ||
| MsiRm, |
There was a problem hiding this comment.
Should we be spelling out Restart Manager (here and/or in the native code)?
There was a problem hiding this comment.
I guess I was following Microsoft's lead here, they always used RM - INSTALLMESSAGE_RMFILESINUSE, MsiRMFilesInUse (Dialog), etc.
There was a problem hiding this comment.
Yeah, that's a typical Microsoft native-code approach. Not so much with managed code, though. And Burn hasn't shied away from long-ass names...
Fixes wixtoolset/issues#6348
Also related to wixtoolset/issues#5208