a few cleanups #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Andrew,
I have made a few cleanups to your Uncle Bob - style rails app, namely getting rid of the pg gem in favor of sqlite3, and just a couple things I saw when studying the code.
Overall I like this approach. My thoughts on this subject is that most of the primary directories (boundaries, interactors, entities), could be encapsulated into a gem, which rails/sinatra/whatever could then require.
It's nice to see other ruby/rails developers starting to flesh out this approach to system architecture. My company will be using an architecture like this for the next revision of our product.