Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Retry with canonicalized url if original url is not gdrive url #304

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Retry with canonicalized url if original url is not gdrive url #304

merged 2 commits into from
Jan 26, 2024

Conversation

wkentaro
Copy link
Owner

@wkentaro wkentaro commented Jan 26, 2024 •
edited
Loading

Close #303

This supports the case

  1. original url redirects to gdrive
  2. the location is outside of us (so url needs 'hl=en')

@wkentaro wkentaro force-pushed the retry_with_canonicalized_url_if_the_original_url_is_not_a_google_drive_url branch from 579f3dd to 523e081 Compare January 26, 2024 15:07
@wkentaro wkentaro self-assigned this Jan 26, 2024
@wkentaro wkentaro added the fix for pr label Jan 26, 2024
@wkentaro wkentaro merged commit ac7fba5 into main Jan 26, 2024
2 checks passed
@wkentaro wkentaro deleted the retry_with_canonicalized_url_if_the_original_url_is_not_a_google_drive_url branch January 26, 2024 15:08
@wkentaro wkentaro mentioned this pull request Jan 26, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@wkentaro wkentaro

Labels
fix for pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: file/folder name cannot be extracted
1 participant
@wkentaro