Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Improve dock feature configuration #1482

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve dock feature configuration #1482

wants to merge 1 commit into from

Conversation

akx
Copy link

@akx akx commented Aug 13, 2024

  • Don't leak features in loop
    • The features were ANDed in to features in the loop, so configuring things to false might not have had an effect
  • Don't crash if configuration is missing
  • Don't use stringly typed getattr magic

@akx
Improve dock feature configuration
1e72059 
* Don't leak `features` in loop
* Don't crash if configuration is missing
@akx akx mentioned this pull request Aug 13, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@akx