Improve DonationNotifier implementation #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
gbirke
force-pushed
the
upgrade-phpstan-level
branch
from
fbe7f25 to
916cb0b
Compare
gbirke
force-pushed
the
donation-mailer-interface-oop
branch
from
670c1c9 to
af4651d
Compare
gbirke
force-pushed
the
donation-mailer-interface-oop
branch
from
af4651d to
ea3d64d
Compare
gbirke
added a commit
to wmde/fundraising-application
that referenced
this pull request
Mar 21, 2024
Create adapter classes that transform the templateArguments objects into arrays, passing them on to the TemplateBasedMailer which only accepts arrays. This is an adaptation for wmde/fundraising-donations#244
gbirke
added a commit
to wmde/fundraising-application
that referenced
this pull request
Mar 22, 2024
Create adapter classes that transform the templateArguments objects into arrays, passing them on to the TemplateBasedMailer which only accepts arrays. This is an adaptation for wmde/fundraising-donations#244
Since user can no longer cancel donations, remove all code that distinguishes between users and administrators. Remove reference to mailer interface, since that is no longer needed. This'll help improving the TemplateMailerInterface to accept only objects. Add `allow-plugins` section to composer.json to allow for new code style. The changes in the CancelDonationUseCase and CancelDonationRequest constructor are a BC break.
gbirke
force-pushed
the
donation-mailer-interface-oop
branch
2 times, most recently
from
f9300c3 to
6e6b3c7
Compare
Abban
approved these changes
Mar 27, 2024
| @@ -59,7 +59,8 @@ | |||
| "config": { | |||
| "discard-changes": true, | |||
| "allow-plugins": { | |||
| "composer/package-versions-deprecated": true | |||
| "composer/package-versions-deprecated": true, | |||
| "dealerdirect/phpcodesniffer-composer-installer": true | |||
There was a problem hiding this comment.
Every time I see this I get a fright
| @@ -0,0 +1,11 @@ | |||
| <?php | |||
| declare( strict_types=1 ); | |||
There was a problem hiding this comment.
There should be a line break before this, I think?
Split interface for donor and template mailer Use value objects instead of arrays This is a backwards-breaking change that needs new implementations in the Fundraising Application
gbirke
force-pushed
the
donation-mailer-interface-oop
branch
from
6e6b3c7 to
95178dc
Compare
gbirke
added a commit
to wmde/fundraising-application
that referenced
this pull request
Apr 5, 2024
Create adapter classes that transform the templateArguments objects into arrays, passing them on to the TemplateBasedMailer which only accepts arrays. This is an adaptation for wmde/fundraising-donations#244
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split interface for donor and template mailer
Use value objects instead of arrays
This is a backwards-breaking change that needs new implementations in
the Fundraising Application