[FollowUp] Anonymize Donations: fix typos, change requests #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moiikana
force-pushed
the
fixup-anonymize-dontations
branch
from
1a281aa to
073f7ee
Compare
- reflects that we rely on isScrubbed having false as a default value and that we only ever call setIsScrubbed(true), so it can be replaced by scrub() https://github.com/wmde/fundraising-donations/pull/247/files#r1675419864
moiikana
force-pushed
the
fixup-anonymize-dontations
branch
from
073f7ee to
1292519
Compare
Merged
Sperling-0
approved these changes
Jul 15, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix typos, change requests for #247