chore!: remove wdqs-proxy #833
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build/wdqs-frontend/default.conf
Outdated
| @@ -23,3 +13,40 @@ server { | |||
| root /usr/share/nginx/html; | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
What is the purpose of this optional commented-out section of server config? Does it need a comment or clarification here?
There was a problem hiding this comment.
Well, no, that is just a left over. Will be removed. Thanks for catching that.
deploy-lts/docker-compose.yml
Outdated
| - "traefik.http.middlewares.wdqs-rate-limit.ratelimit.burst=20" | ||
| # Apply middlewares to the wdqs router | ||
| - "traefik.http.routers.wdqs-router.middlewares=wdqs-prefix,wdqs-headers,wdqs-cors-headers,wdqs-rate-limit" | ||
| # TODO: Set timeouts for the wdqs service |
There was a problem hiding this comment.
Is this something still requiring attention?
There was a problem hiding this comment.
Well, as I now understand, it is basically handled downstream by the X-BIGDATA-MAX-QUERY-MILLIS header already. So this would be extra and I would just remove it. Also Traefik serverstransports configuration seems cursed to me 👻
rti
commented
Feb 10, 2025
This was referenced Feb 14, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bases on work done in #767
maybe we should merge and release #828 first, and make this one go together with #812