Expose connection pool's get timeout via ConnectionOptionsBuilder #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wolf4ood just checking in, anything you'd like changed? |
wolf4ood
approved these changes
May 13, 2024
|
@criminosis released |
|
No worries, thank you @wolf4ood! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was periodically encountering my applications effectively locking up because of Errors stating
Async pool timeout. In my use case I'd rather just wait indefinitely for a connection to be available throughout my application. Prior to this PRgremlin-rswas relying on the default pool connection timeout of 30 seconds, coincidentally the same for both the sync pool (r2d2) and the async pool (mobc) providers.This PR will allow users of the library to modify the timeout, and possibly, for the async pool, opt out of a timeout all together.
@wolf4ood jumped to a PR, but happy to open an issue if you'd like to talk & refine the idea further. If it looks good to you as is mind cutting another release once it's merged?