Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Missing check in client_test #2037

Closed
ManSoSec opened this issue Jan 17, 2019 · 2 comments
Closed

Missing check in client_test #2037

ManSoSec opened this issue Jan 17, 2019 · 2 comments
Assignees
@ejohnstown

Comments

@ManSoSec
Copy link

ManSoSec commented Jan 17, 2019 •
edited
Loading

I am not sure how much this is critical but it seems a check is missing in client.c while it has been done in server.c

https://github.com/wolfSSL/wolfssl/blob/master/examples/client/client.c#L2125
wolfSSL_CTX_SetMinDhKey_Sz(ctx, (word16)minDhKeyBits);

https://github.com/wolfSSL/wolfssl/blob/master/examples/server/server.c#L1410
if (wolfSSL_CTX_SetMinDhKey_Sz(ctx, (word16)minDhKeyBits) != WOLFSSL_SUCCESS) {
err_sys_ex(runWithErrors, "Error setting minimum DH key size");

I can send a pull request.
@ejohnstown
Copy link
Contributor

Thank you for bringing this to our attention. I'll go ahead and fix this and the other two issues.

@ManSoSec
Copy link
Author

Great!

ejohnstown added a commit to ejohnstown/wolfssl that referenced this issue Jan 17, 2019
@ejohnstown
Fix Checks
f6240e5 
1. In the client, check the return code on wolfSSL_CTX_SetMinDhKey_Sz() as it is checked in the server. (Resolves issue wolfSSL#2037.)
2. In HashOutput(), check that the hsHashes exists for the session before hashing. (Resolves issue wolfSSL#2038.)
@ejohnstown ejohnstown mentioned this issue Jan 17, 2019
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@ejohnstown ejohnstown

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ejohnstown @ManSoSec