Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Expose more ECC math functions and improve async shared secret #5868

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Expose more ECC math functions and improve async shared secret #5868

merged 1 commit into from
Dec 8, 2022

Conversation

dgarske
Copy link
Contributor

@dgarske dgarske commented Dec 8, 2022 •
edited
Loading

Description

  • Expose the safe version of point double/add and mulmod_ex with WOLFSSL_PUBLIC_ECC_ADD_DBL.
  • Eliminate int wc_ecc_shared_secret_gen used by async/nb and improve async use of curve spec allocations.

Fixes #4179

Testing

./configure --enable-asynccrypt && make check
./configure --enable-ecc=nonblock --enable-sp=yes,nonblock CFLAGS="-DWOLFSSL_PUBLIC_MP -DECC_USER_CURVES -DHAVE_ECC384" && make check

./configure --enable-asynccrypt --with-intelqa=../QAT1.8 CFLAGS="-DWC_ASYNC_NO_HASH -DWC_ASYNC_NO_CRYPT -DQAT_DEBUG" --enable-debug --disable-shared && make
sudo ./wolfcrypt/test/testwolfcrypt

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@dgarske
Expose the safe version of point double/add and mulmod_ex with `WOLFS…
9ad4e3f 
…SL_PUBLIC_ECC_ADD_DBL`. Eliminate int `wc_ecc_shared_secret_gen` used by async/nb and improve async use of curve spec allocations.
@dgarske dgarske changed the title Expose the safe version of point double/add and mulmod_ex with `WOLFS… Expose more ECC math functions and improve async shared secret Dec 8, 2022
This was referenced Dec 8, 2022
Closed
Merged
@dgarske dgarske requested a review from SparkiDev December 8, 2022 18:47
@dgarske dgarske assigned dgarske and SparkiDev and unassigned dgarske Dec 8, 2022
@SparkiDev SparkiDev merged commit c959d22 into wolfSSL:master Dec 8, 2022
@dgarske dgarske deleted the ecc_pub_math branch December 9, 2022 16:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@SparkiDev SparkiDev SparkiDev approved these changes

Assignees

@SparkiDev SparkiDev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SP math: Functions declared but not exported
2 participants
@dgarske @SparkiDev