Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

More async cb #6783

Merged
merged 4 commits into from
Sep 20, 2023
Merged

More async cb #6783

merged 4 commits into from
Sep 20, 2023

Conversation

bandi13
Copy link
Contributor

@bandi13 bandi13 commented Sep 18, 2023

Refactored WC_NOT_PENDING_E to WC_NO_PENDING_E. Seem to have a passing make check now.

Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just a minor feedback on printf.

* the completion is not detected in the poll like Intel QAT or
* Nitrox */
ret = wolfEventQueue_Remove(&ssl->ctx->event_queue, event);
printf("Queue_Remove: %d",ret);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider removing this debug statement.

@bandi13 bandi13 assigned wolfSSL-Bot and unassigned bandi13 Sep 20, 2023
@dgarske dgarske merged commit f7ca923 into wolfSSL:master Sep 20, 2023
@bandi13 bandi13 deleted the more_async_cb branch September 20, 2023 17:33
dgarske added a commit to dgarske/wolfssl that referenced this pull request Oct 31, 2023
… broken in PR wolfSSL#6783. Was causing re-entry and multiple calls for some operations like DH KeyGen that don't advance state on completion. wolfSSL/wolfAsyncCrypt#71
@dgarske dgarske mentioned this pull request Oct 31, 2023
4 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants