-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
More async cb #6783
Merged
Merged
More async cb #6783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
dgarske
requested changes
Sep 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Just a minor feedback on printf.
* the completion is not detected in the poll like Intel QAT or | ||
* Nitrox */ | ||
ret = wolfEventQueue_Remove(&ssl->ctx->event_queue, event); | ||
printf("Queue_Remove: %d",ret); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider removing this debug statement.
bba3ff8
to
a0a2b64
Compare
a0a2b64
to
da39f66
Compare
dgarske
approved these changes
Sep 20, 2023
dgarske
added a commit
to dgarske/wolfssl
that referenced
this pull request
Oct 31, 2023
… broken in PR wolfSSL#6783. Was causing re-entry and multiple calls for some operations like DH KeyGen that don't advance state on completion. wolfSSL/wolfAsyncCrypt#71
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored WC_NOT_PENDING_E to WC_NO_PENDING_E. Seem to have a passing
make check
now.