-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[Beta fix] Update Sentry to avoid crash in SDK init #13828
[Beta fix] Update Sentry to avoid crash in SDK init #13828
Conversation
Sentry found a crash in their SDK initialisation process: getsentry/sentry-cocoa#4280 It’s difficult to assess the impact, as we don’t have the benefit of any Sentry issues for these crashes. We believe at least 12 devices have been affected in the last 2 weeks. This commit updates us to the latest version, which has the fix for the crash.
Generated by 🚫 Danger |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FatalErrors
won't be reported to Sentry due to watchOS API limitations! https://wp.me/pe5pgL-5uP
If you want to test out the Sentry integration you can manually log an error!
do {
try aMethodThatMightFail()
} catch {
SentrySDK.capture(error: error)
}
Got an error showing with the new SDK (eventually!) I needed to set |
Closes: #13824
Description
Sentry found a crash in their SDK initialisation process: getsentry/sentry-cocoa#4280
It’s difficult to assess the impact, as we don’t have the benefit of any Sentry issues for these crashes. We believe at least 12 devices have been affected in the last 2 weeks.
This PR updates us to the latest version, which has the fix for the crash.
Steps to reproduce
I wasn't able to reproduce the crash – launch the app and check that it works.
@Ecarrion – I saw that you did a test WatchOS crash a few weeks ago. Can you remember how long it took to show in the Sentry UI?
I also added a
fatalError
call in the app (not committed, obviously) and checked to see if the log went to Sentry, but it's not showed up yet. I don't imagine it's not working though...Testing information
Only basic functionality tested.
RELEASE-NOTES.txt
if necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: