Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Subscriptions migrated from PPEC fail to renew with PCP after Vault V3 implementation in version 2.5.0 (2778) #2699

Conversation

Dinamiko
Copy link
Contributor

As of 2.5.0 subscription renewals that were migrated from the PayPal Checkout Gateway are not processing successfully.

Steps To Reproduce

  • Enable the PayPal Checkout (PPEC) plugin
  • Ensure HPOS is disabled
  • Create a subscription using the PPEC plugin
  • Disable PPEC
  • As admin try to renewal the subscription manually
    • Observe that the status remains "Pending Payment" without any log indicators for the renewal process.

This PR fixes the issue by using {$wpdb->prefix}wc_orders instead of $wpdb->wc_orders which does not exist for in non HPOS configurations. It also adds ppec_paypal payment to vault v2 order renewal handler.

…ail-to-renew-with-pcp-after-vault-v-3-implementation-in-version-2-5-0
Copy link
Collaborator

@Narek13 Narek13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Dinamiko. Left a couple of minor suggestions which don't prevent me to approve the PR

@Dinamiko
Copy link
Contributor Author

@Narek13 thanks for the feedback!

…ail-to-renew-with-pcp-after-vault-v-3-implementation-in-version-2-5-0
@Dinamiko Dinamiko merged commit c468c39 into trunk Jan 23, 2025
5 checks passed
@Dinamiko Dinamiko deleted the PCP-2778-subscriptions-migrated-from-ppec-fail-to-renew-with-pcp-after-vault-v-3-implementation-in-version-2-5-0 branch January 23, 2025 09:50
@InpsydeNiklas InpsydeNiklas added this to the 3.0.0 milestone Mar 11, 2025
@Dinamiko Dinamiko added the bug Something isn't working label Mar 13, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants