TODOs

server/shared/procBuilder.go

@@ -192,6 +192,7 @@ func containsItemWithName(name string, items []*BuildItem) bool {
 func (b *ProcBuilder) envsubst(y string, environ map[string]string) (string, error) {
 	return envsubst.Eval(y, func(name string) string {
 		env := environ[name]
+		// TODO: check if we should escape in general (what about \t ...?)
 		if strings.Contains(env, "\n") {
 			env = fmt.Sprintf("%q", env)
 		}

server/store/datastore/build.go

@@ -85,6 +85,8 @@ func (s storage) GetBuildCount() (int64, error) {
 }
 
 func (s storage) CreateBuild(build *model.Build, procList ...*model.Proc) error {
+	// TODO: Verify repoID exist ...
+
 	sess := s.engine.NewSession()
 	defer sess.Close()
 	if err := sess.Begin(); err != nil {