Tools upgrade: Ruby 2.7.4, bash-cache 2.8.0
#1363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version includes a fix that removes the need to run `gem install bundler` before each step.
mokagio
force-pushed
the
mokagio/ruby-2.7.4
branch
from
431ef13 to
40afa55
Compare
Closed
mokagio
force-pushed
the
mokagio/ruby-2.7.4
branch
from
ff2e17e to
40afa55
Compare
mokagio
changed the title
bash-cache 2.8.0bash-cache 2.8.0
cbess
added a commit
to cbess/AztecEditor-iOS
that referenced
this pull request
Aug 6, 2023
commit 4d0522d Merge: 2b54f87 59d5090 Author: Gio Lodi <gio.lodi@automattic.com> Date: Thu Mar 9 12:08:36 2023 +1100 Point `bash-cache` plugin to new `a8c-ci-toolkit` location (wordpress-mobile#1367) commit 59d5090 Author: Gio Lodi <gio@mokacoding.com> Date: Mon Mar 6 21:10:15 2023 +1100 Remove unused YAML anchor and fix indentation in pipeline commit e0526bf Author: Gio Lodi <gio@mokacoding.com> Date: Mon Mar 6 21:09:53 2023 +1100 Point `bash-cache` plugin to new `a8c-ci-toolkit` location While I was at it, I also updated the version to the latest, 2.13.0. This was done via: ``` find . -type f -name "*.yml" -exec sed -i '' 's/automattic\/bash-cache#[0-9.]\{1,\}/automattic\/a8c-ci-toolkit#2.13.0/g' {} + ``` commit 2b54f87 Merge: b7d8a70 d18d0a8 Author: Gio Lodi <giovanni.lodi42@gmail.com> Date: Thu Oct 20 16:59:18 2022 +1100 Add `CHANGELOG.md` (wordpress-mobile#1365) commit d18d0a8 Author: Gio Lodi <gio@mokacoding.com> Date: Thu Oct 20 15:18:16 2022 +1100 Update `PULL_REQUEST_TEMPLATE.md` with note about `CHANGELOG.md` commit 2c73ef5 Author: Gio Lodi <gio@mokacoding.com> Date: Thu Oct 20 14:32:38 2022 +1100 Add changelog entry about changelog itself commit 212ce2f Author: Gio Lodi <gio@mokacoding.com> Date: Thu Oct 20 14:15:12 2022 +1100 Update `CHANGELOG.md` with new format commit b7d8a70 Merge: 91cf065 40afa55 Author: Gio Lodi <giovanni.lodi42@gmail.com> Date: Tue Oct 4 10:29:42 2022 +1100 Tools upgrade: Ruby 2.7.4, bash-cache 2.8.0 (wordpress-mobile#1363) commit 40afa55 Author: Gio Lodi <gio@mokacoding.com> Date: Mon Oct 3 20:00:33 2022 +1100 Use `bash-cache` Buildkite plugin version 2.8.0 This version includes a fix that removes the need to run `gem install bundler` before each step. commit bd8840a Author: Gio Lodi <gio@mokacoding.com> Date: Mon Oct 3 19:59:52 2022 +1100 Use Ruby version 2.7.4 commit 91cf065 Merge: 9d8d9b8 1ce621c Author: Diego Rey Mendez <diegoreymendez@users.noreply.github.com> Date: Wed Aug 10 15:07:41 2022 +0200 Merge pull request wordpress-mobile#1353 from cbess/expose-indentation-actions Expose indentation operations commit 9d8d9b8 Merge: b16c763 7eb60c7 Author: Tony Li <i@crazytony.li> Date: Mon Jul 25 11:11:13 2022 +1200 Merge pull request wordpress-mobile#1359 from wordpress-mobile/remove/circle-ci Remove CircleCI commit 7eb60c7 Author: Jeremy Massel <1123407+jkmassel@users.noreply.github.com> Date: Fri Jul 22 23:23:27 2022 -0600 Trigger Build commit f91511e Author: Jeremy Massel <1123407+jkmassel@users.noreply.github.com> Date: Thu Jul 21 23:03:28 2022 -0600 Remove CircleCI commit 1ce621c Author: C. Bess <cbess@users.noreply.github.com> Date: Sat Mar 26 12:31:51 2022 -0500 cleanup whitespace commit ed55d4a Author: C. Bess <cbess@users.noreply.github.com> Date: Sat Mar 26 12:31:03 2022 -0500 cleanup whitespace commit 4561534 Author: C. Bess <cbess@users.noreply.github.com> Date: Sat Mar 26 12:01:30 2022 -0500 expose indentation operations - make increase/decrease indentation actions visible - cleanup code
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the repo was still using Ruby 2.6.4. There's nothing inherently wrong with it given there hasn't been any update on this in a while.
Still, 2.6.4 doesn't work on Apple Silicon out of the box and that's the recommended development platform internally. Upgrading was straightforward and quick, and might save us some time if/when we'll need to make more changes here.
I tried to upgrade to Xcode 14 as well, but run into some failures. Given we are not actively working on this repo, I think we can merge this PR as-is, and follow up on Xcode 14 in due time via #1364.