-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix an issue with a missing "Mark as Unread" button in the More menu #23917
Conversation
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
d21ea43
to
4cd8e57
Compare
@@ -360,6 +370,17 @@ private final class ReaderPostCellView: UIView { | |||
} | |||
} | |||
|
|||
private func configureSeenCheckmarkIfNeeded() { | |||
guard !isSeenCheckmarkConfigured else { return } | |||
isSeenCheckmarkConfigured = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, why is a special flag used here? If the idea is to prevent repeated changes to image
, maybe a lazy var is more appropriate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit cumbersome, but the view is created eagerly during the setup:
let headerView = UIStackView(alignment: .center, [buttonAuthor, dot, timeLabel, seenCheckmark])
Ideally, I should create it lazily and add it lazily to the stack view, but I felt it was simpler this way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you could make a lazy var seenCheckmar: UIImage
so that this configuration function can be called repeatedly. Maybe it's personal preference, but I'm not a big fan of boolean flag type of states.
* Rename ImageLoadingController * Add LightboxViewController to replace WPImageViewController * Integrate LightboxViewController in Reader * Add Media support in LightboxViewController * Add convenience init to LightboxViewController * Integrate LightboxViewController in SiteMedia * Integrate LightboxViewController in ReaderDetailsCoordinator (cover image) * INtegrate in DefaultContentCoordinator * Integrate LightboxViewController in Guteberg * Integrate LightboxViewController in ExternalMediaPickerViewController * Integrate LightboxViewController in PostSettingsViewController (featured image) * Remove FeaturedImageViewController (ObjC) * Rewrite PostFeaturedImageCell * Integrate LightboxViewController in ReaderCommentsViewController * Update WPRichTextImage to use AsyncImageView * Automatically pick thumbnail when available * Remove WPImageViewController * Update release notes * Remove ImageLoader * Remove ImageDimensionParser * Update MediaItemHeaderView to use AsyncImageView instead of CachedAnimatedImageView * Fix code formatting in RichTextView * Update AnimatedGifAttachmentViewProvider to use GIFImageView directly * Remove SolidColorActivityIndicator * Remove CachedAnimatedImageView * Remove GIFPlaybackStrategy * Update EditorMediaUtility to use ImageDownloader directly (without AuthenticatedImageDownload redirect) * Remove AuthenticatedImageDownload * Update MediaExternalExporter to use ImageDownloader for downloading GIF data * Remove AnimatedImageCache * Remove remaining AlamofireImage usages from the anouncement cells * Remove AlamofireImageCacheAdapter * Remove AlamofireImage * Add ImagePrefetcher * Update releaes notes * Add ImageRequest support in AsyncImageView * Add ImageSize * Fix an issue with blogging reminders flow not being shown after publishing a new post * Remove unused LightNavigationController * Remove BottomSheetViewController usage from BloggingReminders flow * Simplify BloggingRemindersFlowIntroViewController * Add SpacerView * Add BottomToolbarView * Fix notice covering the blogging reminders fow * Replace FancyButton * Add close button to BloggingRemindersFlowSettingsViewController * Fix BloggingRemindersTimeSelectionViewController presentation * Remove FancyButton from BloggingRemindersPushPromptViewController * Remove dismiss button (it now shows back) * Update BloggingRemindersPushPromptViewController layout * Remove FancyButton from BloggingRemindersFlowCompletionViewController * Update BloggingRemindersFlowCompletionViewController layout * Update releaes notes * Fix typo in release notes * Fix compliance popover accessibility settings * Fix an issue with compliance popover not dismissing * Update release notes * Remove unused CircularProgressView extensions * Remove BottomSheetViewController usage from JetpackBrandingCoordinator * Remove ottomSheetViewControllerTests * Remove BottomSheetViewController * Remove DrawerPresentationController * Update release notes * Add Share action to the site link on dashboard * Remove duplicated Share actions * Remove duplicated Strings.ok * Update release notes * Fix layout issues in Privacy Settings * Add assertion * Update release notes * Rename WordPressMedia to AsyncImageKit * Remove MediaHost from AsyncImageKit * Move ImageDownloader.shared to AsyncImageKit * Move AsyncImageView and other related types to AsyncImageKit * Fix unit tests * Cleanup MediaHost initializers * Optimize account lookup * Fix MediaHostTests * Fix crash in ReaderDetailFeaturedImageView * Fix RTL support in WebKitViewController * Use semantic back/forward chevrons in other places * Update StatsBaseCell * Update SiteStatsTableHeaderView * Replace disclosure-chevron and editor-chevron-left * Fix remainig incorrect chevron usages * Remove remainig chevron images * Update release notes * Fix separator insets on homepage * Fix an issue with clear navigation bar background in revision browser * Fix an issue with clear navigation bar background in revision browser * Fix toolbar inset to safe area in revision browser * Modernize menus and stuff * Fix MediaRequestAuthenticatorTests * Remove preflight connection check when sending replies (can be lagging behind) * Fix an issue with comments disppearing if request fails * Update other screens using TextView * Update release notes * Fix formatting * Fix an issue with referrers showing invalid icons * Update release notes * Remove some of the scenarios where isInternetConnected used * Update site menu style on iPhone * Update release notes * Integrate zoom transitions in Theme browser * Update release notes * Fix tint colors in wpios * Remove UIAppColor.brand * Enable zoom transitions in Reader (iPad) * Update release notes * Remove unused isVisibleInScrollView * Enable toolbar hiding on iPad * Fix ReaderDetailFeaturedImageView gradienet showing up when no image is present * Fix an issue with Publisize options appearing in the prepublishing sheet for XMLRPC sites * Fix code formatting and remove unused imports * Move SiteIconView to WordPressUI * Update Share extension to use SiteIconView * Remove UIImageView+Blavatar * Use firstLetter * Update release notes * Disable universal links support for QR code login * Fix an issue with the confirmation screen shown more than once * Update release notes * Enable fast deceleration for filters on the Discover tab * Update release notes * Show selected filter in the Discover navigation bar * Update release notes * Remove unused makeCreateButtonAnnouncementAlertController * Add scroll-to-top button to Reader * Cleanup * Update design for iPad * Add analytics * Update releaes notes * Flatten a nested localized string to avoid `genstrings` failure * Import `WordPressUI` in `SiteIconViewModelTests` Otherwise, it won't build * Add initial MediaPicker implementation * Add initial PostSettingsFeaturedImageCell implementation * Add configurable MediaPicker content * Add ViewModel to PostSettingsFeaturedImageCell * Add reuseIdentifier for featured image cells * Pass selection from MediaPicker to PostSettingsFeaturedImageViewModel * Show upload status using PostMediaUploadItemView * Rename MediaUploadItemViewModel * Add PostSettingsFeaturedImageUploadView to show upload progress * Simlify how the app shows media upload status * Handle upload failure * Implement featured image save * Add support for showing a selected featured image * Add support for removing featured image * Simplify lightbox * Add support for camera as a source * Add .siteMedia(blog:) source * Add ImagePlayground source support * Add ImagePlayground support in MediaPicker * Add free photos and GIFs support to MediaPicker * Remove unused media upload code from PostSettingsViewController * Remove WPTableViewActivityCell * Remove WPProgressTableViewCell * Remvove unused featured image size * Remove more unused code * Remove unused code * Add SiteMediaImageView * Remove unused code * Integrate FeaturedImageDelegate * Fix SiteMediaImage background when loading with spinner * Fix animations * Add zoom transition * Add shadow to more menu * Make the entire cell tappable * Add View action * Add replace action * Show spinner when replacing an image * Remove unused reloadFeaturedImageCell * Update release notse * Revert "Update site menu style on iPhone" This reverts commit 565a34b. * Fix an issue with wrong cover images appearing in Reader (#23914) * Fix an issue with wrong cover images appearing in Reader * Update release notes * Update release notes * Point back to wpios-edition * Fix an issue with non-stable order in Posts and Pages in stats (#23915) * Fix an issue with non-stable order in Posts and Pages in stats * Update release notes * Update release notes * Fix an issue with a missing "Mark as Unread" button in the More menu (#23917) * Add missing toggle read/unread button * Show read status in the list * Update release notes * Update release notes * Add missing social sharing icons (#23918) * Add missing social sharing icons * Update release notes * Update release notes * Update release notes * Fix build * Update UI tests * Use medium font for main navigation area in Reader to align with Home * Remove commented-out code * Add context menus and previews for sites in Reader (#23964) * Fix l10n typo * Add Unsubscribe context menu to Reader sidebar sites * Extract ReaderSiteFavoriteButton * Move actions to ReaderSidebarSubscriptionCell * Extract ReaderSubscriptionContextMenu and add Share * Add Notification Settings and Copy Link buttons * Add context menu for sites in Subscriptions view * Add previews * Fix notification settings sometimes being clipped on iPad * Fix layout in ReaderSubscriptionCel actions * Update release notes * Fix more button color in dark mode * Fix an issue with fullscreen button in reply view clipped by the notch (#23965) * Fix an issue with fullscreen button in reply view clipped by the notch * Update release notes * Fix display of certain topics in Discover recommendations * Remove "Lazy Images" Jetpack option (#23966) * Remove lazy loading: * Add error handling * Update release notes * Update WordPressKit (has lazy-load fix) * Update release notes * Reoder site actions * Update release notes * Add missing imports --------- Co-authored-by: Gio Lodi <gio@mokacoding.com>
* Rename ImageLoadingController * Add LightboxViewController to replace WPImageViewController * Integrate LightboxViewController in Reader * Add Media support in LightboxViewController * Add convenience init to LightboxViewController * Integrate LightboxViewController in SiteMedia * Integrate LightboxViewController in ReaderDetailsCoordinator (cover image) * INtegrate in DefaultContentCoordinator * Integrate LightboxViewController in Guteberg * Integrate LightboxViewController in ExternalMediaPickerViewController * Integrate LightboxViewController in PostSettingsViewController (featured image) * Remove FeaturedImageViewController (ObjC) * Rewrite PostFeaturedImageCell * Integrate LightboxViewController in ReaderCommentsViewController * Update WPRichTextImage to use AsyncImageView * Automatically pick thumbnail when available * Remove WPImageViewController * Update release notes * Remove ImageLoader * Remove ImageDimensionParser * Update MediaItemHeaderView to use AsyncImageView instead of CachedAnimatedImageView * Fix code formatting in RichTextView * Update AnimatedGifAttachmentViewProvider to use GIFImageView directly * Remove SolidColorActivityIndicator * Remove CachedAnimatedImageView * Remove GIFPlaybackStrategy * Update EditorMediaUtility to use ImageDownloader directly (without AuthenticatedImageDownload redirect) * Remove AuthenticatedImageDownload * Update MediaExternalExporter to use ImageDownloader for downloading GIF data * Remove AnimatedImageCache * Remove remaining AlamofireImage usages from the anouncement cells * Remove AlamofireImageCacheAdapter * Remove AlamofireImage * Add ImagePrefetcher * Update releaes notes * Add ImageRequest support in AsyncImageView * Add ImageSize * Fix an issue with blogging reminders flow not being shown after publishing a new post * Remove unused LightNavigationController * Remove BottomSheetViewController usage from BloggingReminders flow * Simplify BloggingRemindersFlowIntroViewController * Add SpacerView * Add BottomToolbarView * Fix notice covering the blogging reminders fow * Replace FancyButton * Add close button to BloggingRemindersFlowSettingsViewController * Fix BloggingRemindersTimeSelectionViewController presentation * Remove FancyButton from BloggingRemindersPushPromptViewController * Remove dismiss button (it now shows back) * Update BloggingRemindersPushPromptViewController layout * Remove FancyButton from BloggingRemindersFlowCompletionViewController * Update BloggingRemindersFlowCompletionViewController layout * Update releaes notes * Fix typo in release notes * Fix compliance popover accessibility settings * Fix an issue with compliance popover not dismissing * Update release notes * Remove unused CircularProgressView extensions * Remove BottomSheetViewController usage from JetpackBrandingCoordinator * Remove ottomSheetViewControllerTests * Remove BottomSheetViewController * Remove DrawerPresentationController * Update release notes * Add Share action to the site link on dashboard * Remove duplicated Share actions * Remove duplicated Strings.ok * Update release notes * Fix layout issues in Privacy Settings * Add assertion * Update release notes * Rename WordPressMedia to AsyncImageKit * Remove MediaHost from AsyncImageKit * Move ImageDownloader.shared to AsyncImageKit * Move AsyncImageView and other related types to AsyncImageKit * Fix unit tests * Cleanup MediaHost initializers * Optimize account lookup * Fix MediaHostTests * Fix crash in ReaderDetailFeaturedImageView * Fix RTL support in WebKitViewController * Use semantic back/forward chevrons in other places * Update StatsBaseCell * Update SiteStatsTableHeaderView * Replace disclosure-chevron and editor-chevron-left * Fix remainig incorrect chevron usages * Remove remainig chevron images * Update release notes * Fix separator insets on homepage * Fix an issue with clear navigation bar background in revision browser * Fix an issue with clear navigation bar background in revision browser * Fix toolbar inset to safe area in revision browser * Modernize menus and stuff * Fix MediaRequestAuthenticatorTests * Remove preflight connection check when sending replies (can be lagging behind) * Fix an issue with comments disppearing if request fails * Update other screens using TextView * Update release notes * Fix formatting * Fix an issue with referrers showing invalid icons * Update release notes * Remove some of the scenarios where isInternetConnected used * Update site menu style on iPhone * Update release notes * Integrate zoom transitions in Theme browser * Update release notes * Fix tint colors in wpios * Remove UIAppColor.brand * Enable zoom transitions in Reader (iPad) * Update release notes * Remove unused isVisibleInScrollView * Enable toolbar hiding on iPad * Fix ReaderDetailFeaturedImageView gradienet showing up when no image is present * Fix an issue with Publisize options appearing in the prepublishing sheet for XMLRPC sites * Fix code formatting and remove unused imports * Move SiteIconView to WordPressUI * Update Share extension to use SiteIconView * Remove UIImageView+Blavatar * Use firstLetter * Update release notes * Disable universal links support for QR code login * Fix an issue with the confirmation screen shown more than once * Update release notes * Enable fast deceleration for filters on the Discover tab * Update release notes * Show selected filter in the Discover navigation bar * Update release notes * Remove unused makeCreateButtonAnnouncementAlertController * Add scroll-to-top button to Reader * Cleanup * Update design for iPad * Add analytics * Update releaes notes * Flatten a nested localized string to avoid `genstrings` failure * Import `WordPressUI` in `SiteIconViewModelTests` Otherwise, it won't build * Add initial MediaPicker implementation * Add initial PostSettingsFeaturedImageCell implementation * Add configurable MediaPicker content * Add ViewModel to PostSettingsFeaturedImageCell * Add reuseIdentifier for featured image cells * Pass selection from MediaPicker to PostSettingsFeaturedImageViewModel * Show upload status using PostMediaUploadItemView * Rename MediaUploadItemViewModel * Add PostSettingsFeaturedImageUploadView to show upload progress * Simlify how the app shows media upload status * Handle upload failure * Implement featured image save * Add support for showing a selected featured image * Add support for removing featured image * Simplify lightbox * Add support for camera as a source * Add .siteMedia(blog:) source * Add ImagePlayground source support * Add ImagePlayground support in MediaPicker * Add free photos and GIFs support to MediaPicker * Remove unused media upload code from PostSettingsViewController * Remove WPTableViewActivityCell * Remove WPProgressTableViewCell * Remvove unused featured image size * Remove more unused code * Remove unused code * Add SiteMediaImageView * Remove unused code * Integrate FeaturedImageDelegate * Fix SiteMediaImage background when loading with spinner * Fix animations * Add zoom transition * Add shadow to more menu * Make the entire cell tappable * Add View action * Add replace action * Show spinner when replacing an image * Remove unused reloadFeaturedImageCell * Update release notse * Revert "Update site menu style on iPhone" This reverts commit 565a34b. * Fix an issue with wrong cover images appearing in Reader (#23914) * Fix an issue with wrong cover images appearing in Reader * Update release notes * Update release notes * Point back to wpios-edition * Fix an issue with non-stable order in Posts and Pages in stats (#23915) * Fix an issue with non-stable order in Posts and Pages in stats * Update release notes * Update release notes * Fix an issue with a missing "Mark as Unread" button in the More menu (#23917) * Add missing toggle read/unread button * Show read status in the list * Update release notes * Update release notes * Add missing social sharing icons (#23918) * Add missing social sharing icons * Update release notes * Update release notes * Update release notes * Fix build * Update UI tests * Use medium font for main navigation area in Reader to align with Home * Remove commented-out code * Add context menus and previews for sites in Reader (#23964) * Fix l10n typo * Add Unsubscribe context menu to Reader sidebar sites * Extract ReaderSiteFavoriteButton * Move actions to ReaderSidebarSubscriptionCell * Extract ReaderSubscriptionContextMenu and add Share * Add Notification Settings and Copy Link buttons * Add context menu for sites in Subscriptions view * Add previews * Fix notification settings sometimes being clipped on iPad * Fix layout in ReaderSubscriptionCel actions * Update release notes * Fix more button color in dark mode * Fix an issue with fullscreen button in reply view clipped by the notch (#23965) * Fix an issue with fullscreen button in reply view clipped by the notch * Update release notes * Fix display of certain topics in Discover recommendations * Remove "Lazy Images" Jetpack option (#23966) * Remove lazy loading: * Add error handling * Update release notes * Update WordPressKit (has lazy-load fix) * Update release notes * Reoder site actions * Update release notes * Add missing imports --------- Co-authored-by: Gio Lodi <gio@mokacoding.com>
Fixes #23916.
Changes:
This change applies to P2s. I don't think regular blogs support this.
To test:
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txt
if necessary.Testing checklist: