Add imports required to compile Keystone for testing
#24537
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 27710 | |
| Version | PR #24537 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 60fc321 | |
| Installation URL | 62t5b2qpg74ko |
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 27710 | |
| Version | PR #24537 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 60fc321 | |
| Installation URL | 1rfs4po5dnqh0 |
mokagio
force-pushed
the
mokagio/add-imports-keystone
branch
2 times, most recently
from
9b8a25d to
d86c65e
Compare
The only iOS version available out of the box with the 16.3 stack.
mokagio
force-pushed
the
mokagio/add-imports-keystone
branch
from
d86c65e to
60fc321
Compare
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a number of import statement that seem necessary to build Keystone for testing. Without them, on my machine, the build fails.
I landed on this PR via two different streams of work:
WordPressUnitTests.xctestplantoKeystoneTests.xctestplanfor clarity (not yet open as a PR)With both, I wanted to build Keystone for testing (
Shift Cmd U), and got compilation failures. Many iterations later, all the required imports are in place.The reason we never noticed despite having a CI step to run Keystone tests is that the scheme was not (never was? 🤔 ) configured to run tests
This has now been rectified.
Testing instructions