-
Notifications
You must be signed in to change notification settings - Fork 15
Wrap ListView and GridView in ScrolledWindow #120
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
The demo did not work correctly: when creating more than 200 widgets and scrolling down, widgets are not dynamically created. Each `Gtk.ListView` or `Gtk.GridView` should be placed in `Gtk.ScrolledWindow` without intermediaries (Scrolling from `Adw.StatusPage` will not work)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This needs a bit more work / attention to detail :)
I see 2 issues
The whole content shifting upwards when adding first new items:
Screencast.from.2024-03-13.23-41-30.mp4
The content width changing
Screencast.from.2024-03-13.23-44-42.mp4
If you revert unrelated changes - that probably fixes them
Please also double check that all properties on ScrolledWindow are necessary
Done. 🫡 |
I also wanted to ask, how welcome is changing the code of an existing demo? That is, I could add text output with "widget loaded/unloaded at position n" and add 500 instead 3 default widgets. One of the features of ListView/GridView is the display of a huge amount of content without hitting performance. |
if it's an improvement go for it
That's an improvement 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Feel free to add yourself to Workbench contributors in about.js
The demo did not work correctly: when creating more than 200 widgets and scrolling down, widgets are not dynamically created. Each
Gtk.ListView
orGtk.GridView
should be placed inGtk.ScrolledWindow
without intermediaries (Scrolling fromAdw.StatusPage
will not work)