Add subscriptions graphql schema #275

tjeerddie · 2023-06-03T09:13:59Z

use processes_resolver in subscription schema to resolve processes of a subscription.
use subscriptions_resolver in processes schema to resolve subscriptions of a process.
add subscriptions db filters and sorting.
add generic filters to remove duplicated code.
use subscriptions_resolver in subscriptions schema to resolve depends_on and in_use_by subscriptions.
make date filter better so you don't need an exact isoformat date.
test subscriptions schema.

codecov-commenter · 2023-06-03T09:16:34Z

Codecov Report

Merging #275 (523fffb) into main (32735ec) will increase coverage by 0.48%.
The diff coverage is 91.46%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #275      +/-   ##
==========================================
+ Coverage   76.07%   76.56%   +0.48%     
==========================================
  Files         154      163       +9     
  Lines        8250     8486     +236     
  Branches     1324     1363      +39     
==========================================
+ Hits         6276     6497     +221     
- Misses       1784     1795      +11     
- Partials      190      194       +4

Impacted Files	Coverage Δ
orchestrator/db/filters/filters.py	`88.09% <33.33%> (-9.41%)`	⬇️
orchestrator/graphql/resolvers/product.py	`91.66% <50.00%> (-0.23%)`	⬇️
...strator/db/filters/generic_filters/range_filter.py	`71.42% <71.42%> (ø)`
orchestrator/graphql/schemas/process.py	`95.00% <76.47%> (-5.00%)`	⬇️
orchestrator/graphql/schemas/product.py	`93.10% <81.81%> (-6.90%)`	⬇️
orchestrator/db/filters/subscription.py	`87.50% <87.50%> (ø)`
orchestrator/graphql/schemas/subscription.py	`97.11% <97.11%> (ø)`
...rchestrator/db/filters/generic_filters/__init__.py	`100.00% <100.00%> (ø)`
...estrator/db/filters/generic_filters/bool_filter.py	`100.00% <100.00%> (ø)`
...rator/db/filters/generic_filters/is_like_filter.py	`100.00% <100.00%> (ø)`
... and 12 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

orchestrator/db/filters/generic_filters/range_filter.py

orchestrator/db/filters/process.py

orchestrator/db/filters/subscription.py

orchestrator/db/sorting/subscription.py

orchestrator/graphql/schemas/subscription.py

orchestrator/graphql/schemas/process.py

orchestrator/db/filters/generic_filters/bool_filter.py

test/unit_tests/graphql/test_processes.py

orchestrator/db/filters/generic_filters/bool_filter.py

orchestrator/db/filters/generic_filters/range_filter.py

orchestrator/graphql/resolvers/subscription.py

orchestrator/graphql/schemas/subscription.py

Mark90

Few small remarks but looks good, nice refactoring @ the filters!

- use processes_resolver in subscription schema to resolve processes of a subscription. - use subscriptions_resolver in processes schema to resolve subscriptions of a process. - add subscriptions db filters and sorting. - add generic filters to remove duplicated code.

also remove it from tests. add filter_by to new variable instead of overwriting it.

fix generic_values_in_column_filter by lowercasing the column value.

- improve descriptions of relation fields. - update single subscription tests to check product blocks.

tjeerddie marked this pull request as draft June 3, 2023 09:14

tjeerddie force-pushed the add-core-subscriptions-graphql branch 4 times, most recently from 02ac5ca to 3034322 Compare June 13, 2023 13:58