-
Notifications
You must be signed in to change notification settings - Fork 16
Draft: 931 feature add role based access control to running workflows #939
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: main
Are you sure you want to change the base?
Draft: 931 feature add role based access control to running workflows #939
Conversation
This was already enabled in resume_process, but we weren't passing the user model in to be checked.
CodSpeed Performance ReportMerging #939 will not alter performanceComparing Summary
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #939 +/- ##
==========================================
+ Coverage 83.49% 83.50% +0.01%
==========================================
Files 205 205
Lines 10206 10225 +19
Branches 1022 1025 +3
==========================================
+ Hits 8521 8538 +17
- Misses 1414 1415 +1
- Partials 271 272 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
orchestrator/workflow.py
Outdated
authorize_callback(user_model) | ||
if not authorize_callback(user_model): | ||
logger.error("authorize_user_from_state: FORBIDDEN") | ||
#TODO not sure that step name is available here, but could put it on state? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be available in the StateInputStepFunc
object
e4a5e3a
to
6e33048
Compare
Here's my first pass at adding auth for inputstep per #931.
I'd appreciate feedback on my present approach, but I'd also like to address the following loose ends before merging:
@workflow
auth interacts with@inputstep
auth and resolving any issues identified in the process.