removes conditional render option to edit description on wf/task metad… #1897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atapage, requires orch-core 4.0.0
🦋 Changeset detectedLatest commit: af7cf39 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
DutchBen
reviewed
May 5, 2025
| }, | ||
| // description: { |
There was a problem hiding this comment.
Either uncomment this or remove it. Is there a reason to keep it?
DutchBen
approved these changes
May 5, 2025
| @@ -258,7 +258,7 @@ export interface Step { | |||
| export interface WorkflowDefinition { | |||
| workflowId: string; | |||
| name: string; | |||
| description?: string; | |||
| description: string; | |||
There was a problem hiding this comment.
By right, this is a breaking change. I also saw that this type is used in multiple other places:
Did you verify all of them? Same goes for the TaskDefinition type below
| description={value} | ||
| /> | ||
| ) : null, | ||
| renderData: (value, row) => ( |
There was a problem hiding this comment.
Do not forget to add changeset to this PR
ricardovdheijden
approved these changes
May 6, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes conditional render option to edit description on wf/task metadata page, requires orch-core 4.0.0
Note: align the release of this feature with the core release, and combine it with the breaking change of the TARGET=validation feature.