326 service configuration select options #1937
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the whole tree when selecting product bocks by name
🦋 Changeset detectedLatest commit: 3484bc6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
DutchBen
reviewed
May 19, 2025
| } | ||
|
|
||
| const { checked, data } = changedOption; | ||
| const shouldAdd = checked === 'on'; |
There was a problem hiding this comment.
Suggested change
| const shouldAdd = checked === 'on'; | |
| const shouldAddIds = checked === 'on'; |
DutchBen
reviewed
May 19, 2025
| const shouldAdd = checked === 'on'; | ||
|
|
||
| expandAll(); | ||
| return shouldAdd ? selectIds(data.ids) : deselectIds(data.ids); |
There was a problem hiding this comment.
Suggested change
| return shouldAdd ? selectIds(data.ids) : deselectIds(data.ids); | |
| return shouldAddIds ? selectIds(data.ids) : deselectIds(data.ids); |
DutchBen
reviewed
May 19, 2025
| const items2Map = productBlockInstances.reduce((acc, curr) => { | ||
| const name = getFieldFromProductBlockInstanceValues( | ||
| curr.productBlockInstanceValues, | ||
| 'name', |
There was a problem hiding this comment.
Is there a way to use an enum here so 'name' doesn't have to be hardcode?
DutchBen
approved these changes
May 19, 2025
Georgi2704
reviewed
May 20, 2025
| text={t( | ||
| 'selectByNameButtonText', | ||
| )} | ||
| onClick={() => togglePopover()} |
There was a problem hiding this comment.
onClick={togglePopover}
Georgi2704
approved these changes
May 20, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#326
Adds new button to the product blocks tree to select all product blocks of a certain type