Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add Webhooks module #28

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Add Webhooks module #28

merged 1 commit into from
Mar 8, 2023

Conversation

riebeekn
Copy link
Contributor

This PR adds a Webhook module for validating web hook requests from WorkOS, i.e. https://workos.com/docs/webhooks/securing-your-webhook-endpoint/validating-events-are-from-workos

My first PR around this was a little premature, this version takes much inspiration from the stripity-stripe library.

@jacobiajohnson jacobiajohnson self-assigned this Feb 24, 2023
Copy link
Contributor

@jacobiajohnson jacobiajohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @riebeekn, apologize for the delayed review here, really appreciate you taking the time to work on this. I just have one small suggestion but everything else looks good!

lib/workos/webhooks/webhooks.ex Outdated Show resolved Hide resolved
@jacobiajohnson
Copy link
Contributor

Thanks again! Once the PR is updated/rebased we should be good to merge this in.

@riebeekn
Copy link
Contributor Author

riebeekn commented Mar 7, 2023

@jacobiajohnson Updated the branch with latest and also rebased the parameter rename. Let me know if you need any other changes. Thanks!

@jacobiajohnson jacobiajohnson merged commit 6f7c1a4 into workos:main Mar 8, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants