Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

hackily move apply_order_by function clause generation to adapter #385

Merged
merged 1 commit into from
Jul 16, 2023

Conversation

woylie
Copy link
Owner

@woylie woylie commented Jul 16, 2023

relates to #238

@woylie woylie force-pushed the adapter-apply-order-by-2 branch from a895060 to 7b08cb7 Compare July 16, 2023 13:46
@codecov
Copy link

codecov bot commented Jul 16, 2023

Codecov Report

Patch coverage: 80.00% and project coverage change: -0.22 ⚠️

Comparison is base (dae56b2) 87.75% compared to head (a895060) 87.54%.

❗ Current head a895060 differs from pull request most recent head 7b08cb7. Consider uploading reports for the commit 7b08cb7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #385      +/-   ##
==========================================
- Coverage   87.75%   87.54%   -0.22%     
==========================================
  Files          15       15              
  Lines         874      867       -7     
==========================================
- Hits          767      759       -8     
- Misses        107      108       +1     
Impacted Files Coverage Δ
lib/flop/schema.ex 96.38% <75.00%> (-1.40%) ⬇️
lib/flop/adapter/ecto.ex 94.66% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@woylie woylie marked this pull request as ready for review July 16, 2023 13:53
@woylie woylie merged commit 202b1b0 into main Jul 16, 2023
@woylie woylie deleted the adapter-apply-order-by-2 branch July 16, 2023 13:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant