-
Notifications
You must be signed in to change notification settings - Fork 25
Add wp cache supports <feature>
command
#84
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Changes from all commits
e0d220d
a9258f5
ea2b62b
d848236
cd12d8d
4da2223
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -147,3 +147,13 @@ Feature: Managed the WordPress object cache | |
""" | ||
Warning: Ignoring the --url=<url> argument because flushing the cache affects all sites on a multisite installation. | ||
""" | ||
|
||
@require-wp-6.1 | ||
Scenario: Checking if the cache supports a feature | ||
Given a WP install | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @danielbachhuber I don't understand what use this has. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
@janw-me
I think the test is fine as it is. It doesn't need to be overly complex. |
||
When I try `wp cache supports non_existing` | ||
Then the return code should be 1 | ||
|
||
When I run `wp cache supports set_multiple` | ||
Then the return code should be 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danielbachhuber I'm guessing that you add this line, run some command and it updates the README.
Can you show me how to do this?
Might come in handy next time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After adding that line
README.md
regeneration can be even skipped and Github Actions will create a separate PR after the main PR is merged - see https://github.com/wp-cli/.github/blob/main/.github/workflows/reusable-regenerate-readme.ymlThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. However, to avoid the separate PR (which was unnecessary because I was already in the code), I simply ran
wp scaffold package-readme ./
in the repository directory.