Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix typo in package-readme command doc #225

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Fix typo in package-readme command doc #225

merged 1 commit into from
Jan 11, 2024

Conversation

ernilambar
Copy link
Member

Path: src/ScaffoldPackageCommand.php L220

Current:

underlaying

Changed to:

underlying

@ernilambar ernilambar requested a review from a team as a code owner January 11, 2024 11:11
@swissspidy
Copy link
Member

@ernilambar Thanks for fixing all these typos everywhere. Instead of doing all of that manually, it would be easiest to just set up a GitHub Action to do this. See https://github.com/WordPress/plugin-check/blob/571a65a3f993fcc5bb7faf04fbb5d16c696cd599/.github/workflows/spell-check.yml for an example.

This could be added to https://github.com/wp-cli/.github/tree/7f6b72e950f06caabb5e8875e1f85f4a561cb63b/.github/workflows and all WP-CLI repositories would automatically benefit from automated spell check.

Would you be interested in submitting a PR for that?

@ernilambar
Copy link
Member Author

@swissspidy Sure. I will try that approach.

@ernilambar
Copy link
Member Author

@swissspidy Should this Spell Check action be kept inside workflows/reusable-code-quality.yml file?

@swissspidy
Copy link
Member

Sure that works

@swissspidy swissspidy added this to the 2.0.6 milestone Jan 11, 2024
@swissspidy swissspidy merged commit 358511b into wp-cli:main Jan 11, 2024
4 of 5 checks passed
@ernilambar ernilambar deleted the fix-spelling-error branch February 15, 2024 16:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants