Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add github option for --ci in scaffold package tests #237

Merged
merged 4 commits into from
Mar 23, 2024
Merged

Add github option for --ci in scaffold package tests #237

merged 4 commits into from
Mar 23, 2024

Conversation

ernilambar
Copy link
Member

@ernilambar ernilambar commented Mar 20, 2024 •
edited
Loading

Fixes: #217

  • Add github option for --ci argument in scaffold package-tests
  • Two files are added for this CI (apart from common test files).
    • behat.yml - Same file from the root is copied
    • testing.yml - Template file is kept at dot-github/workflows folder. This will be copied to .github/workflows

@ernilambar ernilambar marked this pull request as ready for review March 20, 2024 10:01
@ernilambar ernilambar requested a review from a team as a code owner March 20, 2024 10:01
wojtekn
wojtekn approved these changes Mar 20, 2024
View reviewed changes
Copy link

@wojtekn wojtekn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks clear, and works fine:

% vendor/bin/wp scaffold package-tests wp-cli-shim --ci=github 
Success: Created package test files.

@danielbachhuber danielbachhuber self-requested a review March 21, 2024 08:07
danielbachhuber
danielbachhuber requested changes Mar 21, 2024
View reviewed changes
Copy link
Member

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some basic tests for this?

@ernilambar
Copy link
Member Author

@danielbachhuber PR has been updated.

@danielbachhuber danielbachhuber self-requested a review March 23, 2024 10:40
danielbachhuber
danielbachhuber approved these changes Mar 23, 2024
View reviewed changes
Copy link
Member

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ernilambar !

@danielbachhuber danielbachhuber added this to the 2.0.6 milestone Mar 23, 2024
@danielbachhuber danielbachhuber merged commit 8819088 into wp-cli:main Mar 23, 2024
39 checks passed
@ernilambar ernilambar deleted the feature/gh-actions branch March 25, 2024 08:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@danielbachhuber danielbachhuber danielbachhuber approved these changes

@wojtekn wojtekn wojtekn approved these changes

Assignees
No one assigned
Labels
command:scaffold-package command:scaffold-package-tests
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

Support GitHub Actions CI config
3 participants
@ernilambar @danielbachhuber @wojtekn