Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs: 📝 Added information on creating release to README #169

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

Mattbober
Copy link
Member

Description

@Mattbober Mattbober requested a review from a team as a code owner September 7, 2023 15:22
README.md Outdated

The steps involved with creating a new release are as follows :

1. Make sure the version in package.json is updated as appropriate
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like a more detailed and step-by-step. Think someone completely new to the team is going to try this for the first time.

Suggested change
1. Make sure the version in package.json is updated as appropriate
1. Update the version in `package.json`
2. Run `npm install` and check the new version in the generated `package-lock.json`

README.md Outdated
The steps involved with creating a new release are as follows :

1. Make sure the version in package.json is updated as appropriate
2. Make sure develop has all the changes that are intended to be in the release
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. Make sure develop has all the changes that are intended to be in the release
2. Create a PR against `develop` with the version update. Review and merge the PR

README.md Outdated

1. Make sure the version in package.json is updated as appropriate
2. Make sure develop has all the changes that are intended to be in the release
3. Merge `develop` into the `main` branch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3. Merge `develop` into the `main` branch
3. Create a PR from `develop` into the `main` branch and make sure it includes all the changes that are intended to be in the release. Reviewed and merge the PR

README.md Outdated
1. Make sure the version in package.json is updated as appropriate
2. Make sure develop has all the changes that are intended to be in the release
3. Merge `develop` into the `main` branch
4. Launch a fresh Atlas Blueprint and ensure changes are there and the version is correct.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
4. Launch a fresh Atlas Blueprint and ensure changes are there and the version is correct.
4. In the User Portal (production), create a new Atlas App using the Shopify Blueprint and verify if changes are there and the version is correct.

README.md Outdated
2. Make sure develop has all the changes that are intended to be in the release
3. Merge `develop` into the `main` branch
4. Launch a fresh Atlas Blueprint and ensure changes are there and the version is correct.
5. Create a new release in Github with the tag as the latest version with `main` as the target. (For description you can use the `generate release notes` button)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
5. Create a new release in Github with the tag as the latest version with `main` as the target. (For description you can use the `generate release notes` button)
5. Create a new release in Github with the tag as the latest version with `main` as the target. (For description you can use the `generate release notes` button)
6. Post a message to [#team-pe-titan-public](https://wpengine.slack.com/archives/C04SJP4UBB7) using the following template:
> 🚀 Atlas Shopify Blueprint - Version X.Y.Z 🚀
> We have released a new version of the blueprint. <Short sentences summarising the changes added>. For more details, follow this link: https://github.com/wpengine/atlas-shopify-blueprint/releases/tag/X.Y.Z

@Mattbober Mattbober merged commit 86b4d88 into develop Sep 11, 2023
@Mattbober Mattbober deleted the mbober/TITAN-514 branch September 11, 2023 15:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants