Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix: Added auto-close menu in mobile #298

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Fix: Added auto-close menu in mobile #298

merged 1 commit into from
Feb 24, 2025

Conversation

Fran-A-Dev
Copy link
Collaborator

  • Added a new handleMenuItemClick callback function that sets isMenuOpen to false
  • Added an onClick handler to each MenuItem component that calls handleMenuItemClick

Menu closes now when user clicks on item in mobile

@headless-platform-by-wp-engine Headless Platform by WP Engine
Copy link

Check out the recent updates to your Headless Platform preview environment:

App Environment URL Build
faustjs.org preview-env-fix/primary-menu-close-on-mobile https://hx…wered.com ✅ (logs)

Learn more about preview environments in our documentation.

colinmurphy
colinmurphy approved these changes Feb 24, 2025
View reviewed changes
Copy link
Collaborator

@colinmurphy colinmurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fran-A-Dev LGTM 🚀

Tested preview link on Safari in iPhone 14 with IOS 18 and the issue was fixed 😄

@colinmurphy colinmurphy merged commit 2dc9d5f into main Feb 24, 2025
4 checks passed
@colinmurphy colinmurphy deleted the fix/primary-menu-close-on-mobile branch February 24, 2025 16:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@colinmurphy colinmurphy colinmurphy approved these changes

@kellenmace kellenmace Awaiting requested review from kellenmace

@moonmeister moonmeister Awaiting requested review from moonmeister

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fran-A-Dev @colinmurphy