add return after MathSharedStore::ReportError

wpilibsuite · Feb 21, 2025 · 06a80cd · 06a80cd
1 parent 2d70846
commit 06a80cd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/wpimath/src/main/java/edu/wpi/first/math/MathUtil.java b/wpimath/src/main/java/edu/wpi/first/math/MathUtil.java
@@ -227,6 +227,7 @@ public static Translation2d slewRateLimit(
       Exception e = new IllegalArgumentException();
       MathSharedStore.reportError(
           "maxVelocity must be a non-negative number, got " + maxVelocity, e.getStackTrace());
+      return next;
     }
     Translation2d diff = next.minus(current);
     double dist = diff.getNorm();
@@ -254,6 +255,7 @@ public static Translation3d slewRateLimit(
       Exception e = new IllegalArgumentException();
       MathSharedStore.reportError(
           "maxVelocity must be a non-negative number, got " + maxVelocity, e.getStackTrace());
+      return next;
     }
     Translation3d diff = next.minus(current);
     double dist = diff.getNorm();

diff --git a/wpimath/src/main/native/include/frc/MathUtil.h b/wpimath/src/main/native/include/frc/MathUtil.h
@@ -229,6 +229,7 @@ constexpr Translation2d SlewRateLimit(const Translation2d& current,
   if (maxVelocity < 0_mps) {
     wpi::math::MathSharedStore::ReportError(
         "maxVelocity must be a non-negative number, got {}!", maxVelocity.value());
+    return next;
   }
   Translation2d diff = next - current;
   units::meter_t dist = diff.Norm();
@@ -256,6 +257,7 @@ constexpr Translation3d SlewRateLimit(
   if (maxVelocity < 0_mps) {
     wpi::math::MathSharedStore::ReportError(
         "maxVelocity must be a non-negative number, got {}!", maxVelocity.value());
+    return next;
   }
   Translation3d diff = next - current;
   units::meter_t dist = diff.Norm();