Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use Miklast high resolution field render #6185

Merged
merged 2 commits into from
Jan 14, 2024

Conversation

sciencewhiz
Copy link
Contributor

@sciencewhiz sciencewhiz requested a review from a team as a code owner January 9, 2024 05:10
@sciencewhiz
Copy link
Contributor Author

This looks good in pathweaver:
image

Field border isn't correct in glass:
image-1

This makes it so glass scaling bug doesn't affect field border
significantly
@sciencewhiz
Copy link
Contributor Author

I cropped the image so that the aspect ratio is 2:1, which virtually matches the aspect ratio of the field, and glass draws the field border correctly.

image

@sciencewhiz
Copy link
Contributor Author

That last picture came from an instrumented build of glass, but I think I might have left some functional changes in also. I'll double check with a clean glass build tonight

@sciencewhiz
Copy link
Contributor Author

Looks fine with glass 2024.1.1 also

@sciencewhiz
Copy link
Contributor Author

With #6222 merged it isn't necessary to crop, but I think it's probably better to leave it cropped to waste less space.

@PeterJohnson PeterJohnson merged commit d2ee423 into wpilibsuite:main Jan 14, 2024
27 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2024 field image json - appears to still be incorrect
2 participants