Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[examples] Don't reset encoders when resetting odometry #6329

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

rzblue
Copy link
Member

@rzblue rzblue commented Jan 30, 2024

This isn't necessary anymore, and could lead to potentially incorrect results if used with can-based encoders (eg, if the data returned immediately after reset isn't up-to-date)

@rzblue rzblue requested review from a team as code owners January 30, 2024 22:59
Copy link
Contributor

@KangarooKoala KangarooKoala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, for what it's worth. I could've sworn there was an issue or PR related to this, but I can't seem to find it anymore- Maybe I'm just remembering wrong?

@PeterJohnson PeterJohnson merged commit cb094e4 into wpilibsuite:main Jan 31, 2024
27 checks passed
@rzblue rzblue deleted the dont-reset-encoders branch February 1, 2024 22:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants