[glass] Fix custom image padding to maintain aspect ratio #7648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterJohnson
approved these changes
Jan 7, 2025
|
Just a note that you can get the field boundary by loading the json file instead of the raw image. |
pjreiniger
pushed a commit
to bzlmodRio/allwpilib
that referenced
this pull request
Jan 8, 2025
katzuv
pushed a commit
to katzuv/allwpilib
that referenced
this pull request
Feb 16, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My previous change from #7214 caused custom Field2d images to be slightly squished vertically, this fixes the padding so the image keeps the same aspect ratio.
Before:
After: