Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[wpimath] Implement Pose2d and Pose3d rotateAround() #7659

Merged
merged 13 commits into from
Jan 13, 2025
Merged

[wpimath] Implement Pose2d and Pose3d rotateAround() #7659

merged 13 commits into from
Jan 13, 2025

Conversation

TheComputer314
Copy link
Contributor

@TheComputer314 TheComputer314 commented Jan 8, 2025 •
edited
Loading

Closes #7657

@github-actions github-actions bot added the component: wpimath Math library label Jan 8, 2025
@TheComputer314 TheComputer314 changed the title Implement Pose2d and Pose3d rotateAround() [wpimath] Implement Pose2d and Pose3d rotateAround() Jan 10, 2025
@TheComputer314 TheComputer314 marked this pull request as ready for review January 10, 2025 16:26
@TheComputer314 TheComputer314 requested a review from a team as a code owner January 10, 2025 16:26
calcmogul
calcmogul requested changes Jan 10, 2025
View reviewed changes
Copy link
Member

@calcmogul calcmogul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just needs unit tests.

@TheComputer314
Copy link
Contributor Author

Looks good. Just needs unit tests.

Done.

calcmogul
calcmogul previously approved these changes Jan 10, 2025
View reviewed changes
@PeterJohnson PeterJohnson merged commit cd92b07 into wpilibsuite:main Jan 13, 2025
45 checks passed
@TheComputer314 TheComputer314 deleted the RotateAroundInPoseClasses branch January 13, 2025 19:56
katzuv pushed a commit to katzuv/allwpilib that referenced this pull request Feb 16, 2025
@TheComputer314 @katzuv
[wpimath] Add Pose2d and Pose3d rotateAround() (wpilibsuite#7659)
4d90b99
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@chauser chauser chauser left review comments

@calcmogul calcmogul calcmogul approved these changes

Assignees
No one assigned
Labels
component: wpimath Math library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Pose2d and Pose3d rotateAround()
4 participants
@TheComputer314 @chauser @calcmogul @PeterJohnson