Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[wpilibc, wpilibh, cmd] Improve HID direction documentation (NFC) #7672

Merged

Conversation

KangarooKoala
Copy link
Contributor

@KangarooKoala KangarooKoala commented Jan 13, 2025

Closes #7611.

Not completely sure about whether the link to the WPILib docs page should stay there or if there's a better way to include it (that also plays nicely with formatting).

CommandJoystick.h doesn't have the getX() and getY() direction clarifications since it doesn't have them.

@KangarooKoala KangarooKoala requested review from a team as code owners January 13, 2025 01:46
Copy link
Contributor

This PR modifies commands. Please open a corresponding PR in Python Commands and include a link to this PR.

Co-authored-by: Tyler Veness <calcmogul@gmail.com>
@KangarooKoala KangarooKoala force-pushed the hid-direction-documentation branch from 6972421 to 0f232fc Compare January 16, 2025 05:02
@PeterJohnson PeterJohnson merged commit 72541c1 into wpilibsuite:main Jan 20, 2025
45 checks passed
@KangarooKoala KangarooKoala deleted the hid-direction-documentation branch January 20, 2025 04:34
katzuv pushed a commit to katzuv/allwpilib that referenced this pull request Feb 16, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
component: command-based WPILib Command Based Library component: wpilibc WPILib C++ component: wpilibj WPILib Java
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document axis conventions for Joystick.getDirection()
3 participants