[wpiutil] Remove broken StackWalker library #7777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calcmogul
force-pushed
the
wpiutil-remove-broken-stack-walker-library
branch
from
b6f918c to
5a1b204
Compare
calcmogul
force-pushed
the
wpiutil-remove-broken-stack-walker-library
branch
from
5a1b204 to
47994c9
Compare
A Discord user reported that StackWalker gives blank stacktraces: https://discord.com/channels/176186766946992128/368993897495527424/1261940029287301150 MSVC's C++23 support is unstable, so we can't use std::stacktrace yet. In the meantime, we can just return an empty string and remove the unmaintained StackWalker library and its hacky upstream_utils script.
calcmogul
force-pushed
the
wpiutil-remove-broken-stack-walker-library
branch
from
47994c9 to
4394316
Compare
PeterJohnson
previously approved these changes
Feb 13, 2025
PeterJohnson
approved these changes
Feb 13, 2025
katzuv
pushed a commit
to katzuv/allwpilib
that referenced
this pull request
Feb 16, 2025
A Discord user reported that StackWalker gives blank stacktraces. MSVC's C++23 support is unstable, so we can't use std::stacktrace yet. In the meantime, we can just return an empty string and remove the unmaintained StackWalker library and its hacky upstream_utils script.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Discord user reported that StackWalker gives blank stacktraces: https://discord.com/channels/176186766946992128/368993897495527424/1261940029287301150
MSVC's C++23 support is unstable, so we can't use std::stacktrace yet. In the meantime, we can just return an empty string and remove the unmaintained StackWalker library and its hacky upstream_utils script.