-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix first_image not resolving correctly in subdirectories #61
Conversation
I actually ended up swapping it over to use |
FYI I tried this branch locally and confirmed that it solves the problem described in #59. I have actually (temporarily) installed this branch in our RTD env and now the live site is working: https://pangeo-forge.readthedocs.io/en/latest/introduction_tutorial/intro_tutorial_part1.html Thanks for your extremely quick help on this! |
Could you add in a test case that fails before and passes with this PR? |
Apparently a test for this exists ( I'll fix the test and I think ill change all URLs to use something like |
We shouldn't break existing functionality.
This PR doesn't need to add relative path support for field lists. |
I fixed it, the fix is a bit weird but I think it is ok until #60.
I meant maybe we should consider not supporting them for now at all, but never mind that. |
Fixes #59.
I'm actually not 100% if there is a more proper way to do this is, so the solution is a bit hacky, but this will be dealt with in #60 in a more proper way anyways.
(Another solution would be to use
Path(page_url).parent
instead ofogp_site_url
which would resolve the relative link by itself, but that didn't seem like a cleaner solution, and once again this is a somewhat temporary fix)