Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Support relative module imports #40

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Support relative module imports #40

wants to merge 2 commits into from

Conversation

vladimyr
Copy link
Contributor

@vladimyr vladimyr commented Jun 7, 2020 •
edited
Loading

Alters module resolution algorithm to support importing modules relative to the root directory. Root directory may be one of:

  1. Current working directory if wren is running in a REPL mode
  2. Parent directory of the invoked script

@vladimyr vladimyr force-pushed the relative-imports branch 5 times, most recently from 9c3eba8 to eadd035 Compare June 7, 2020 18:12
@vladimyr vladimyr force-pushed the relative-imports branch from eadd035 to c6bba81 Compare June 7, 2020 23:44
@vladimyr vladimyr changed the title Support relative module imports in REPL Support relative module imports Jun 7, 2020
@vladimyr vladimyr force-pushed the relative-imports branch from c6bba81 to 9707748 Compare June 7, 2020 23:47
@ruby0x1 ruby0x1 closed this Jun 12, 2020
@ruby0x1 ruby0x1 reopened this Jun 13, 2020
@ruby0x1 ruby0x1 changed the base branch from master to main June 13, 2020 21:25
@joshgoebel
Copy link
Contributor

@vladimyr Isn't this already handled by wren_modules support?

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vladimyr @joshgoebel @ruby0x1