Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

xdg-open nuisance #195

Closed
yeban opened this issue Jun 10, 2015 · 4 comments · Fixed by #227
Closed

xdg-open nuisance #195

yeban opened this issue Jun 10, 2015 · 4 comments · Fixed by #227
Labels
bug

Comments

@yeban
Copy link
Collaborator

yeban commented Jun 10, 2015

https://groups.google.com/forum/#!topic/sequenceserver/uuFF6l0Yheo
@yannickwurm
Copy link
Member

I vote to kill this "feature" as it introduces a usability bug.

@yeban yeban added the bug label Sep 16, 2015
@terfilip
Copy link
Contributor

For some reason this gets fixed for me when I replace

 `xdg-open #{server_url}`

with

 system "xdg-open #{server_url}"

From what I read both invoke a new process but the first one returns the output and the second returns the exit code. Perhaps the first one makes it hang because SS is waiting on the output. Not sure how this will work on other platforms

/cc @yeban

@yeban
Copy link
Collaborator Author

yeban commented Nov 14, 2015

That has to be it - brilliant! Could you send a PR?

@terfilip terfilip mentioned this issue Nov 14, 2015
Merged
yeban added a commit that referenced this issue Nov 15, 2015
@yeban
Merge remote-tracking branch 'filip/master'
3b546b8 
close #195

* filip/master:
  Switching from backticks to system

Signed-off-by: Anurag Priyam <anurag08priyam@gmail.com>
@yeban
Copy link
Collaborator Author

yeban commented Nov 15, 2015

Note: Could try spawn if this doesn't fix it completely.

yeban added a commit that referenced this issue Mar 18, 2016
@yeban
Merge branch 'backport' into 1.0.x
57b94da 
Pull in fix for #195 and the undocumented Passenger-Gemfile issues
from master.

* backport:
  Switching from backticks to system
  Do not include Gemfile with the gem.
  split on newline because some filenames contain spaces

Signed-off-by: Anurag Priyam <anurag08priyam@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switching from backticks to system
3 participants
@yeban @yannickwurm @terfilip