-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Browser "back" button function #386
Comments
This and a few other issues like this is why we still have the beta tag. As a temporary workaround, I hold the Cmd button on my Mac when I click submit. This opens the results page in a new tab (works in Chrome). Surely one should be able to do the same in Chrome on Linux/Windows using Ctrl button? I agree that the back button should take the user back to the filled form. But I am not so sure about 'modify search' and 'new search' buttons in the results page. I do think that a 'reset form' / 'start new' button would be handy on the search page. I also want SequenceServer to pre-populate the form with data (query, selected databases, advanced options) from the last search anytime a user visits the search page. This is one of the reasons I want a 'reset form' / 'start new' button on the search page rather on the results page. What do you think about that? |
A "reset form" button at the search page would be good, too, I agree. But IMHO the "edit search" / "new search" buttons on the results page are quite essential. The function of the browser's back button can be tricky to define in a platform- and browser-independent manner. Also, consider that people might want to integrate sequenceserver with their other systems and may therefore want to submit searches to sequenceserver directly from other websites. In that case, they would have no way to reach the sequenceserver search page or modify the search, because the browser back button would take them back to the other website. Note that NCBI Blast also has an "Edit and Resubmit" button on the results page. |
Sorry, I have not responded because I don't have clarity on the implementation. Give me a couple more days. If you want to send a PR for your markdown request in the meantime, I should be able to review it. |
Back button in the browser now takes you back to a filled search form instead of resetting it. The underlying implementation is such that new and edit search buttons can be easily added, either directly into SequenceServer or by the website that embeds SequenceServer. I agree with having new and edit search buttons in SequenceServer's results page, however, I don't have the capacity to implement it at the moment - adding new user-interface elements requires considerable thought. We can keep that for a 2.0.x point release or 3.0. Three things to remember for anyone wanting to implement this, including my future self:
|
Two things: First, clear sessionStorage before sending to search form, thus fixing a bug in the implementation. Second, clear query string when search form is reloaded similar to sessionStorage (#481). Signed-off-by: Anurag Priyam <anurag08priyam@gmail.com>
Hi,
I am using version 1.1.0.beta12 and Chrome browser.
After performing a blast search, I get the results page. When I click the "Back" button in the browser, it takes me back to the initial page of sequenceserver, but the sequence that I blasted, the database selection, and the blast parameters have all disappeared. If I want to search the same sequence in a different database with the same parameters, I need to fill everything again.
I think
The text was updated successfully, but these errors were encountered: