Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix sidebar and FASTA ID wrapping #804

Merged
merged 4 commits into from
Oct 21, 2024
Merged

Fix sidebar and FASTA ID wrapping #804

merged 4 commits into from
Oct 21, 2024

Conversation

3lviend
Copy link
Collaborator

@3lviend 3lviend commented Oct 3, 2024

issue #802

  • Sidebar option selected
    image

  • Share results
    image

Copy link
Collaborator

@tadast tadast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, just one change request

public/js/hits.js Outdated Show resolved Hide resolved
@3lviend 3lviend requested a review from tadast October 7, 2024 04:05
Copy link
Collaborator

@tadast tadast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, thanks Elvin.

@djleite would you like to test to confirm this fixes the issue you've raised?

@djleite
Copy link

djleite commented Oct 15, 2024

@3lviend - thank you.

I see two issues still

  1. it seems that when I blast nucleotide to protein I don't get any option to download FASTA files.

image

  1. there is no grey boarder appearing when moused over.

https://www.loom.com/share/49ebf76b3ffe44899272c6fdb653f03b?sid=a2738378-f7b2-4e0e-84e7-b14171e29a43

@tadast
Copy link
Collaborator

tadast commented Oct 21, 2024

it seems that when I blast nucleotide to protein I don't get any option to download FASTA files.

Download links are disabled when you query against database that was formatted without parse_seqids, I did a test with a correctly formatted DB and the links show up. Shout if that's not right @djleite

@tadast tadast merged commit 481f570 into master Oct 21, 2024
4 of 5 checks passed
@tadast tadast deleted the fix/sidebar-and-table branch October 21, 2024 11:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants