Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

airframe-http: Add RPC call logging #1076

Merged
merged 3 commits into from
May 14, 2020
Merged

airframe-http: Add RPC call logging #1076

merged 3 commits into from
May 14, 2020

Conversation

xerial
Copy link
Member

@xerial xerial commented May 14, 2020

No description provided.

@xerial xerial requested review from shimamoto and takezoe May 14, 2020 05:25
@codecov
Copy link

codecov bot commented May 14, 2020

Codecov Report

Merging #1076 into master will decrease coverage by 0.00%.
The diff coverage is 76.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1076      +/-   ##
==========================================
- Coverage   82.31%   82.31%   -0.01%     
==========================================
  Files         270      270              
  Lines       10258    10274      +16     
  Branches      670      666       -4     
==========================================
+ Hits         8444     8457      +13     
- Misses       1814     1817       +3     
Impacted Files Coverage Δ
...rame/http/finagle/filter/HttpAccessLogWriter.scala 94.11% <ø> (ø)
...wvlet/airframe/http/router/HttpRequestMapper.scala 93.93% <ø> (ø)
...c/main/scala/wvlet/airframe/http/HttpContext.scala 73.33% <40.00%> (-16.67%) ⬇️
...rame/http/finagle/filter/HttpAccessLogFilter.scala 77.17% <90.90%> (+2.78%) ⬆️
.../main/scala/wvlet/airframe/http/router/Route.scala 87.50% <100.00%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 079ac12...6fde48c. Read the comment docs.

@xerial xerial mentioned this pull request May 14, 2020
76 tasks
Copy link
Member

@takezoe takezoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good!

@xerial xerial merged commit 119ada2 into wvlet:master May 14, 2020
@xerial xerial deleted the rpc-log branch May 14, 2020 15:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants