Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upgrade to Scala 2.12.12, 2.13.3 #1199

Merged
merged 1 commit into from
Aug 3, 2020
Merged

Conversation

xerial
Copy link
Member

@xerial xerial commented Aug 2, 2020

These Scala versions added -Xasync option, so that scala-async can be efficiently implemented by using the compile-time information. The previous version of scala-async was a macro-based implementation, which was slow and incomplete.

Related:

scala-async will support Scala.js too. This would be useful for writing Future-based async code instead of writing chains of Futures (e.g., Conductor's Future-based operation code will benefit from scala-async). I think reading this SIP https://docs.scala-lang.org/sips/async.html is good enough to understand the motivation why scala-async was developed.

@codecov
Copy link

codecov bot commented Aug 2, 2020

Codecov Report

Merging #1199 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1199   +/-   ##
=======================================
  Coverage   83.20%   83.20%           
=======================================
  Files         289      289           
  Lines       11042    11042           
  Branches      732      732           
=======================================
  Hits         9187     9187           
  Misses       1855     1855           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a8660f...0e500db. Read the comment docs.

@xerial xerial requested a review from a team August 2, 2020 08:15
@xerial xerial merged commit b07b7ac into wvlet:master Aug 3, 2020
@xerial xerial mentioned this pull request Dec 4, 2020
90 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant