-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
airframe-rx: Add RxOption[A] #1214
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1214 +/- ##
==========================================
- Coverage 83.20% 83.19% -0.01%
==========================================
Files 289 291 +2
Lines 11042 11073 +31
Branches 732 713 -19
==========================================
+ Hits 9187 9212 +25
- Misses 1855 1861 +6
Continue to review full report at Codecov.
|
@shimamoto Let me merge this PR as it's becoming a blocker for supporting gRPC streaming #1226 #1227 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for simplifying Rx[Option[A]] handling. Currently, we need to nest multiple map calls:
This code will be simpler like:
This PR also supports Rx[A].toOption if A is Option[_] type
This also closes #1200