wxt/storage doesn't work for MV2

[aklinker1]

Describe the bug

Because wxt/storage uses chrome, in MV2 it requires a callback parameter. However, that parameter is not passed, and it is assumed the storage returns a promise, like it does for MV3 or the browser object.

TypeError: can't access property "...", res is undefined

But since it expects a callback, it returns undefined instead of a promise and we get the error from above.

Reproduction

repro.zip

Steps to reproduce

pnpm dev:firefox

And open the background devtools

System Info

System:
    OS: macOS 14.2.1
    CPU: (8) arm64 Apple M1 Pro
    Memory: 1.36 GB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.20.3 - ~/.asdf/installs/nodejs/18.20.3/bin/node
    npm: 10.7.0 - ~/.asdf/plugins/nodejs/shims/npm
    pnpm: 9.13.0 - ~/.asdf/installs/nodejs/18.20.3/bin/pnpm
    bun: 1.1.27 - ~/.bunv/bin/bun
  Browsers:
    Chrome: 131.0.6778.86
    Safari: 17.2.1
  npmPackages:
    wxt: ^0.19.13 => 0.19.16

Used Package Manager

pnpm

Validations

• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[aklinker1]

Released in https://github.com/wxt-dev/wxt/releases/tag/storage-v1.0.1

[avi12]

Any estimate of when it'll be pushed to wxt?

[aklinker1]

It's a subdependency, so update it and you can already use it

[aklinker1]

# Might work?
pnpm upgrade @wxt-dev/storage

# But this is what I usually do to upgrade a subdependency
pnpm i @wxt-dev/storage@latest
pnpm rm @wxt-dev/storage
pnpm why @wxt-dev/storage