Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Upgrade to c12@2 so config is loaded as ESM #1182

Merged
merged 2 commits into from
Nov 16, 2024

Conversation

aklinker1
Copy link
Collaborator

@aklinker1 aklinker1 commented Nov 16, 2024

Seems to have just worked, no problems. I don't think this is a breaking change, but we'll include it in v0.20.0 and mention it in the upgrade steps just to be safe.

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (0.20.0-breaking-changes@96445c9). Learn more about missing BASE report.

Additional details and impacted files
@@                    Coverage Diff                     @@
##             0.20.0-breaking-changes    #1182   +/-   ##
==========================================================
  Coverage                           ?   81.26%           
==========================================================
  Files                              ?      124           
  Lines                              ?     6517           
  Branches                           ?     1088           
==========================================================
  Hits                               ?     5296           
  Misses                             ?     1204           
  Partials                           ?       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aklinker1 aklinker1 marked this pull request as ready for review November 16, 2024 22:35
@aklinker1 aklinker1 merged commit cbbd70e into 0.20.0-breaking-changes Nov 16, 2024
12 checks passed
@aklinker1 aklinker1 deleted the load-config-as-esm branch November 16, 2024 22:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant